Ad
  • Custom User Avatar

    Approved.

  • Custom User Avatar

    Dumb mistake by me. Fixed.

  • Custom User Avatar

    [[]] is a 1x0 matrix, not an NxN matrix.

  • Custom User Avatar

    fixed. the exponent is now distributed over the entire double range.

  • Custom User Avatar
  • Custom User Avatar

    I updated the assertion messages, can you check it out ?

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    I've updated the kata:

    • The "make it easier" feature with Latin script was removed. Now num_to_russian() requires Cyrillic outputs and russian_to_num() always receives Cyrillic inputs.
    • The Floats section was updated, with much simpler "whole units" and "-ths".
    • Every dictionary removed.
    • Also fixed a bug with "одна тысяча" outputting "2000" for some reason.

    Thanks for your honest opinion and not frowning upon the kata for those issues.
  • Custom User Avatar

    Honestly, I don't think Cyrillic vs Latin would matter at all to someone who doesn't know Russian. I'd just be copy and pasting everything either way, so if Cyrillic is easier for Russian speakers it seems fine to me.

  • Custom User Avatar

    Writing this through my phone, no access to the laptop.

    I have noticed the tendency of people creating their own dictionaries for this kata, instead of using the given ones. And honestly, I don't blame them. The current description is still a complete dogwater, even after so many issues resolved.

    I'm highly considering on removing the dictionaries entirely and make the description only in Latin. For Russian speakers, I will just put a disclaimer, saying that they don't have to read the following instructions and that the Cyrillic inputs will be valid. But I have a dilemma with russian_to_num(). Should I keep its inputs Cyrillic or change it to Latin?

    If you have any more suggestions or you see a problem in my considerations, please, share them. When I arrive home, I'll get on fixing them, since this kata was abandoned by me since the end of May.

  • Custom User Avatar

    A few suggestions from someone who knows zero Russian:

    • I'd definitely prefer just sticking to either Latin or Cyrillic, rather than the mix of both. I understand you're trying to make it easier, but I don't understand Russian regardless of the script, so I'd rather not understand one thing than two.
    • Currently the paragraph about gender omits Cyrillic, as opposed to the rest of the description which uses both.
    • I'm not sure why you've complicated the description of "десятых", "сотых", "тысячных", and "десятитысячных". If I'm understanding correctly, they have direct English counterparts of "tenths", "hundredths", "thousandths" and "ten-thousandths" and are used the same way.
    • Same thing with translating "целых", googling this tells me this means "whole" or "unit", which makes sense (5.2 is "five whole units and 2 tenths") rather than "replaces the dot". It also clarifies why 1 might be a special case.
    • I might just omit the preloaded dictionaries. Figuring out why some values are included and others aren't is harder than just building your own dictionary and including whatever you want. Even in your own solution you ended up extending the dictionary for the teens.

    Could definitely be a cool kata, but the above were some pain points for someone coming in with no background.

  • Custom User Avatar

    I've updated the description with a detailed specification of the input.

  • Loading more items...