Resolved, new fixed and random tests for each requirement

The tests aren't currently isolating these validation requirements:

* The white king (K) and black king (k) must not be in adjacent spaces.
* Pawns (P or p) can’t be on the first rank (bottom row) or the eighth rank (top row).

It's also missing random tests.

I tried. :] It may also just be inexperience and insecurity showing.

I'm not sure there are Best Practices in BF. :P

Double-spaced for legibility and makes sure to clean up after itself. I don't know about best practices, but this definitely has good manners.

I never insist on biased random tests; it can be a fixed test, which could also be a nice small case.

Biased random generation could start with generating three numbers x < y < z that all have gcd /= 1 pairwise ( primes is simplest ), generating [ x, y, x*z, x*y*z ], then possibly adding more numbers as long as they don't include z.

'think so.

Is it better now?

Looks to me like the tables' headers are a bit misleading:

• "product of" describes how one value in one row is built
• the left column actually shows the value for that product...
• ... while the header is closure({2,3}), which is actually the whole possible values (hence rows) together.

So, in my comprehension, closure({2,3}) should be the title of the whole table, and not the header of one column. Same kind of problems goes with the second table (but not exactly the same, since the information is organized a bit differently)

edit: I'd even give the products first, then the values in a second column. But that's a matter of preferences, at this point.

Done. Now it's 4 groups: 1-10, 11-20, 21-30, 31-40

Changed to pure set comparisons

I think a set would be appropriate.

Fixed

The first fixed case is passing an empty dict rather than a set.

Thank you for all the help. I published a new one at https://www.codewars.com/kata/68879d6c77dbd29efef56292 if you want to check it out :)