Ad
  • Custom User Avatar

    [[]] is a 1x0 matrix, not an NxN matrix.

  • Custom User Avatar
  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    Honestly, I don't think Cyrillic vs Latin would matter at all to someone who doesn't know Russian. I'd just be copy and pasting everything either way, so if Cyrillic is easier for Russian speakers it seems fine to me.

  • Custom User Avatar

    A few suggestions from someone who knows zero Russian:

    • I'd definitely prefer just sticking to either Latin or Cyrillic, rather than the mix of both. I understand you're trying to make it easier, but I don't understand Russian regardless of the script, so I'd rather not understand one thing than two.
    • Currently the paragraph about gender omits Cyrillic, as opposed to the rest of the description which uses both.
    • I'm not sure why you've complicated the description of "десятых", "сотых", "тысячных", and "десятитысячных". If I'm understanding correctly, they have direct English counterparts of "tenths", "hundredths", "thousandths" and "ten-thousandths" and are used the same way.
    • Same thing with translating "целых", googling this tells me this means "whole" or "unit", which makes sense (5.2 is "five whole units and 2 tenths") rather than "replaces the dot". It also clarifies why 1 might be a special case.
    • I might just omit the preloaded dictionaries. Figuring out why some values are included and others aren't is harder than just building your own dictionary and including whatever you want. Even in your own solution you ended up extending the dictionary for the teens.

    Could definitely be a cool kata, but the above were some pain points for someone coming in with no background.

  • Custom User Avatar

    You need to specify the input in the description. e.g. the image is represented as single char * split over multiple lines, it will always have length/width of blah, holes in circles will never include the circle's edge, etc.

  • Custom User Avatar

    Looks like there's still one underspecified case, when the word is a single uppercase letter. It seems from tests that it's supposed to capitalize the first letter of the result, even if that letter wasn't in the original text? e.g. F -> If

  • Custom User Avatar

    That still leaves this test in a confusing spot:

    text: "WOULD'NT"
    word_list: ["wouldn't"]
    

    As the 'N' is in the incorrect position, but remains uppercase in the expected result.

    Edit: Nevermind, I just understood the entirely uppercase exception.

  • Custom User Avatar

    Perhaps I missed something, but this case seems ambiguous:

    text: "illBE-ING"
    word_list: ["ill-being"]
    

    As it could be solved with two transpositions, which would correct the "BE-" to lowercase "-be", but could also be done by a deletion of the '-' and an insertion of an '-', which would leave the "BE" uppercase.

  • Custom User Avatar
  • Custom User Avatar

    A few issues with this:

    • The original method needs to be static
    • You're testing for valid/invalid input, but haven't specified what values count as valid
    • You need to specify intermediate rounding that you're doing for each tenant as well as the overall rounding (also should specify half-up/down/even)
    • Missing random tests
    • The specifications of brackets could be more clear. The example table is good, but you still need to specify where those values came from.
  • Custom User Avatar

    Apparantly not at all... looks like this was from 3.0, I had just never noticed it. That just seemed to be the page with the most detail.

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    The assertion messages should provide information about what was wrong (see the docs).

    As dfhwze noted, this isn't likely to be approved, but it's good to know for another kata.

  • Loading more items...