In general, no it's not good practice to put everything on one line. In this case, it's fine. This is a very pythonic solution, this would be just fine as is in almost any codebase (depending on usecase).