In general, no it's not good practice to put everything on one line. In this case, it's fine. This is a very pythonic solution, this would be just fine as is in almost any codebase (depending on usecase).

is it good practice to put everything in one line? it's elegant, but may get hard to read, once things get complicated.