approved, but can't mark suggestion as resolved

Merged.

As the author of the groovy translation, I second this.

That's not true. It expects False for another reason.

"entered_code" equal to zero is considered invalid. it's just not written directly in the condition

Both tests (they're not exactly the same) expect False, your code is returning True for the first one. Not a kata issue.

Two inputs like that
input: 0 False September 5, 2014 September 25, 2014
But one wrong, one right

Python Fork that replaces last digit of date with last digit of day

Java Translation

Rejected, please see remarks in fork

Please, aprove the Groovy Fork

Changes in Sample Tests:

• Fixed the order of arguments in assertions

JUnit assertion Assertions.assertEquals(expected, actual) takes the EXPECTED value as the FIRST argument and the actual as the second.

The implementor of the initial Groovy translation did this the other way around and assertion failure will result in an incorrect message. For instance, if we hardcode the return value of decode() function as 'Boo', test-failure message will be

expected: <Boo> but was: <hello>

instead of proper failure message

expected: <hello> but was: <Boo>

Changes in Random Tests:

• Minor refactorings with no impact on the test behavior

JS fork resolving this issue

• updated to node 18
• used mocha/chai assertions and lodash for randomness
• added sample tests (this issue)
• added random tests in addition to kind of randomized tests
• provided inputs on failure

Enabled in this fork