Ad
  • Custom User Avatar

    As I recently mentioned on discord, I changed my mind. Do what you think is the best

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar
  • Custom User Avatar

    I would love to hear other's opinion before fixing anything as I don't agree with your opinion.

    In the input description is says that :"All coordinates and dimensions are integers."

    So I think that indicates that it could be any integers (positive, negative, large, small) and the is not expected to take in way an advantage of it being some limited range.

  • Custom User Avatar
  • Custom User Avatar
  • Custom User Avatar

    Oh my gosh. Thank you so much. I'll go right in and edit it. Try to keep that code clean.

  • Custom User Avatar

    He's talking about the starter code... the code that the user gets when they open the kata in the trainer for the first time. Here it is, I've replaced the trailing spaces with underscores:

    function digitRacers(str){_
    
    }_
    
  • Custom User Avatar

    I've spent over an hour looking for the spaces you mention but I can't find them. Where exactly are they and what do you mean by "initial code"?

  • Custom User Avatar

    okay. thank you, natan. appreciate your help in improving this kata. it just doesn't take much to overwhelm me lol

  • Custom User Avatar

    Thank you, Kacarott for the clarification. I will try and fix these issues but it will take some time as Im moving very slowly today. But I will work on them one at a time. And natan, I will try to address these issues but please be patient. Ill post the edit link also though not sure how to do it using markdown. I will post each hopefully resolved issue after I have dealt with it.

  • Custom User Avatar

    1.Trailing spaces means a space at the end of a line, ie. after a semicolon or bracket

    3.This means it is cut short and the remaining string replaced with "...". You can fix this by adding chai.config.truncateThreshold = 0; at the top of the tests (for both sample tests, and full tests)

  • Custom User Avatar
    1. trailing spaces? where do you mean? its standard to have them after commas.
    2. i will add a fixed test with all digit groups included.
    3. I dont understand. You mean something is omitted?
    4. Im not sure what could be done about this though I know Ive had this same problem often when running tests for a kata i want to submit. You are welcome to edit this if youd like. ive left this kata open to editing by others.
    5. empty string as input is more like error handling and I didnt want any of that in this kata.
      I am running on very low energy as Im an elderly person and chonic pain issues and poor sleep, so if you decide to exit this kata yourself it is fine with me.
  • Custom User Avatar

    fixed, and also massively improved the random tests (they were expecting 0 most of the time) and added assertion mesages

  • Custom User Avatar
  • Loading more items...