Ad
  • Custom User Avatar
  • Custom User Avatar

    ah sorry, I did not notice. fixed. (that's a strong case against hardcoding the assertion messages...)

  • Custom User Avatar

    mismatched message & test, it seems

        it "should translate 1000 to M" $ solution 1889 `shouldBe` "MDCCCLXXXIX" -- issue here
    
  • Custom User Avatar

    a new issue should be opened if the problem exists in other languages

  • Custom User Avatar

    when you report an issue, you have to give more details as to what the issue is. MDCCCLXXXIX is the correct translation for 1889, so i'm closing this. feel free to provide more details. also, it looks like you solved the kata, but did not come back to close your issue, please don't do that

  • Custom User Avatar

    There is an issue in Haskell's sample test (L16)

    module RomanNumeralsSpec where
    import Test.Hspec
    import RomanNumerals (solution)
    
    spec :: Spec
    spec = do
      describe "Some tests" $ do
        it "should translate 1 to I" $ solution 1 `shouldBe` "I"
        it "should translate 4 to IV" $ solution 4 `shouldBe` "IV"
        it "should translate 6 to VI" $ solution 6 `shouldBe` "VI"
        it "should translate 14 to XIV" $ solution 14 `shouldBe` "XIV"
        it "should translate 21 to XXI" $ solution 21 `shouldBe` "XXI"
        it "should translate 89 to LXXXIX" $ solution 89 `shouldBe` "LXXXIX"
        it "should translate 91 to XCI" $ solution 91 `shouldBe` "XCI"
        it "should translate 984 to CMLXXXIV" $ solution 984 `shouldBe` "CMLXXXIV"
        it "should translate 1000 to M" $ solution 1889 `shouldBe` "MDCCCLXXXIX" -- issue here
        it "should translate 1889 to MDCCCLXXXIX" $ solution 1889 `shouldBe` "MDCCCLXXXIX"
        it "should translate 1989 to MCMLXXXIX" $ solution 1989 `shouldBe` "MCMLXXXIX"