Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Yes, that's a really good practice. Thanks 😉
I LOVE your use of the "ISSUER" dictionary; It makes it easier to add to or adjust later.
this makes sense
Missing sample tests
Missing useful assertion messages
Missing
from solution import small_word_helper
/import solution
in actual test suite (Refer to snippet template code of sample test)Initial solution setup is missing the parameter
sentence
For following code, using
string
as a variable name is bad because it shadows the built-in string module .Also, there exists a
randint
/sample
/choice
methods from the random moduleThe same fix for this should be applied to your other translations (if any
Test Cases
The function parameter ->
list
is shadowing a built-in. In case you wondered what that means So please change it tolst
List size should not be fixed to 2, this can easily make hard-coding solutions by length passable
Missing useful assertion messages
Please create a copy of
list
(which should be named aslst
) in the assertions before passing to the function calls of reference solution so that input mutation can be prevented.Missing imports for solution ->
from solution import list_lower_case
Description
I suggest you dive deep into documentation and fix existing issues of your translations before writing new ones ^^
I appreciate the feedback.
This my second translation I've ever submitted.
If you have any other tips or feedback, I'd love to read it.
Function name should use
snake_case
No random tests
Missing solution import in actual test suite
Edge cases are invalid as per such constraints:
For any Minecraft professionals, note that wood being converted into 4 sticks wasn't intentional. I know that wood is converted into 4 planks first and those planks are converted into 8 sticks. I just forgot about the planks being converted first some how...
.
I revised the descirption to closely match your suggestion, hope you find it more clear for you and the perspective of others?
Hmm. I have never played mincraft. So I found the above instructions very confusing because it looks more like just an example of what you could do with those items, rather than the actual recipe for building a pickaxe.
To remove any ambiguity it might be better to re-word that like:
it was more for fun :D
approved, sorry if i kinda wasted some of your time writing all of the other items.
Great first kata! I feel like this could definitely be a relevant/useful function for a game.
regex is useful if you know it. just takes some practice.
Loading more items...