Ad
  • Custom User Avatar

    So this translation has a lot to check:

    • Upgraded the version from 8 (on original kumite) to 17 + JUnit from 4 to 5;
    • Instead of Map object, the function now returns Attributes class object, cuz before the values were all strings, which does not looks good in comparison with the other languages (defined in preloaded section);
    • Added the table from the external link and removed the latter altogether to resolve this issue;
    • Made the description language-agnostic (same issue);
    • Explicitly wrote about the rules on how to retrieve the max skill level (according to another issue);
    • Added more comprehensive logging, testing structure, WA messages, etc.;

    Because that's a BIG fork, I'd like to listen to others' opinions on whether to approve, edit or whatever else.

    (created with the help of Katafix)

  • Custom User Avatar

    also the last two examples are using the score = 0, although it's intended to be 10 and 20.

  • Custom User Avatar
    • Not sure if the map should have the same name Attributes as the class.
    • The original version of Java is 8, albeit the current latest one is 17 (I mean, this fork is 6 years old, but approving that with old version sounds weird)... That means you can change JUnit from 4 to 5 for better testing coverage/messages.
    • You can just use the type Map<String, Object> for the attributesm with that you can store both numbers and arrays and whatever else as values as long as they're considered Object values. Upd: Map doesn't behave well with Object type, so maybe you can create a class with all needed parameters?
  • Custom User Avatar
  • Custom User Avatar

    If you extend this Kata to allow for let's say 0 <= flats/sharps <= 25 and 100's of random tests, it would become more mature.

  • Custom User Avatar
    1. You are lacking random tests.
    2. You are lacking edge case tests ((A) more than 6 accidentals, (B) more than 12 accidentals)
    3. From the description it is clear that enharmonic equivalence is not applicable (Db != C#), however nothing is being said about octave equivalence.
    • Does C############# get normalized to C#? (B)
    • Does C########### get normalized to Cb? (A)
      --
      Other than that I hope this series continues at some point.
  • Custom User Avatar
  • Custom User Avatar

    Well, I haven't looked at the whole composition, but at 7:20 (where there is a double barline, a key signature change using two naturals & five sharps, with the notation sempre p) the music is in B major for those 6 measures.

  • Custom User Avatar

    Here: https://youtu.be/iRkMBjuqpWo?t=439, it's linked to the minute 7:19, since the compass starts arround the beggining of the second 20. Also see the bars, starting from the third one, up to the next 6, it modulates from Bb Maj to A# Maj.

    Also, this piece uses quite a lot of "unusual" scales, but this is not strange to Chopin compositions.

  • Custom User Avatar

    Chopin! no kidding... can you specify the six bars where this takes place?

  • Custom User Avatar

    The A# Major scale is more of a theoretical scale, usually the songs that could be in A# are written in its enharmonic equivalente Bb. This is done beacuse it´s more practical to only have 3 flats rather than have 4 sharps and 3 double-sharps.Yet some pieces, essentially in classical music, sometimes modulate to this scale during the song like Chopin's Polonaise-fantaisie in A-flat major, Op. 61, which modulates to A# major for six bars.

  • Custom User Avatar

    Can you please direct me to a piece of music written in the key of A# major? I'm looking for mor info. Thanks!

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar
  • Custom User Avatar

    just a note...

    Mmmmh, correct. I always thought that the @Test methods were instance methods of the same instance, and not creating different instances for each method... How weird... :o

    But the loop still stays more "DRY" and easier to maintain. ;)

  • Loading more items...