nice!

Hi,

I don't do rust myself, so I cannot tell. That test uses a macro, and this specific test is only closing the instance, without calling any other method (afaict...).

My solution doesn't rely on recusion, but after passing some tests (somewhere between 37 and 54) it panics with

thread 'tests::failure::properties_and_methods_vs_locking::unlocked_only_close' has overflowed its stack
fatal runtime error: stack overflow


Caused by:
  process didn't exit successfully: `/workspace/target/debug/deps/challenge-07bd72047d917620 --show-output -Z unstable-options --format json` (signal: 6, SIGABRT: process abort signal)

Any idea why?

yeah, that one is the issue from years ago that is still opened. It's chemically incorrect, but considering the task, it's still doable (numerically/mathematically) without problems on user's side (as long as they stick to the task only)

edit: and numerically, it shoud have 0 H, so. But again, the molecule cannot exist, yeah.

ethenyne should have 2 H elements:

python:

5000 random tests...
ethen-1-yne: {'H': 2, 'C': 2} should equal {'C': 2}
ethen-1-yne: {'H': 2, 'C': 2} should equal {'C': 2}
ethenyne: {'H': 2, 'C': 2} should equal {'C': 2}
ethenyne: {'H': 2, 'C': 2} should equal {'C': 2}
eth-1-en-1-yne: {'H': 2, 'C': 2} should equal {'C': 2}
ethenyne: {'H': 2, 'C': 2} should equal {'C': 2}
ethenyne: {'H': 2, 'C': 2} should equal {'C': 2}

Actually, can en and yn even be on same bond position? Looks like you are having multiple bonds between same two atoms, which is very weird. These cases do not occur in javascript, and should also be stripped from other languages.

Nevermind, that alkyl is optional. I found one last 'issue' before completing the kata.

The description states that arsines (and equivalents) have an alkyl prefix; however it can also be an aromatic cycle prefix, as this example shows from random tests:

triphenylarsine

Another random test:

13-amido-9-butyl-13-chloro-6,6-difluoro-3-heptadecyl-8-imino-5,7,10,12-tetraiodo-2-pentadecyl-5,10,11,12-tetra[nonyl]phosphinotridecan-1-oate

However, the spec stipulates that the suffix pattern for ester is alkyl " " alkan position "oate".

I believe this is an invalid molecule according to your own specs.

EDIT: or is the alkyl part optional and this test case is alkan position "oate"?

That's a cheat. Don't use that.

I found your objection here confusing until I thought about it.

Fundamentally, I agree. However, I think the underlying problem isn't the logic of planets leaving the system. That's a symptom. The problem is that the orbits change. As you note, if a planet leaves the system on the left, all other planets shift to fill lower orbits. However, if a planet is destroyed the same thing happens. The logic is consistent and solvable, but it's weird. There's a sort of extra movement built into it.

My biggest complaint, I think, is that the series didn't build upon itself. It would have been great if each new entry in the series added instead of being essentially the same with a different skin.

See above, I think the timing assessments are off by a factor of 10.

Yes, random tests Javascript

ffs, I thought I had fixed that... x/ Yes, it should be "propenoyl..."

random tests, I guess?

This one bothers me:

15-[1,2,2-triamino]propenanoyloxy-2,4,5,12-tetra[2-[[4,5,5-tribromo-1,4,6,7-tetrachloro]hept-2-enyl]arsino[1,2-diamino]ethenoxycarbonyl]hexen-3,5-diynylhexadec-10,13-diynoic acid

It has propenanoyloxy in it.

This has both an alkene en and alkane an suffix, before the oyloxy.

Yet, examples, such as 4-propanoyloxypentanoic acid and prop-2-enoyloxy..., never show this combination.

How do you explain propenanoyloxy?

In general

• Can any alkene, alkyne, alkenyne have an as additional suffix or only in front of oyloxy?
• In your summary, you sometimes use alk, sometimes alkan as prefix; What do you mean in these cases?
  • (alk) -> is this just a radical?
  • (alkan) -> is this a radical, with alkane/alkene/alkyne?

ester                 .                   (alkyl) ...oate
                      (alk)oxycarbonyl
                      (alkan)oyloxy

got it, thanks!

js fork approved